Replaced use of NSInvocation with direct IMP calls for performance.

Mantle · May 18, 2015 · 097177c · 097177c
1 parent 79ae468
commit 097177c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 29 deletions.
diff --git a/Mantle/MTLJSONAdapter.m b/Mantle/MTLJSONAdapter.m
@@ -370,13 +370,9 @@ + (NSDictionary *)valueTransformersForModelClass:(Class)modelClass {
 	for (NSString *key in [modelClass propertyKeys]) {
 		SEL selector = MTLSelectorWithKeyPattern(key, "JSONTransformer");
 		if ([modelClass respondsToSelector:selector]) {
-			NSInvocation *invocation = [NSInvocation invocationWithMethodSignature:[modelClass methodSignatureForSelector:selector]];
-			invocation.target = modelClass;
-			invocation.selector = selector;
-			[invocation invoke];
-
-			__unsafe_unretained id transformer = nil;
-			[invocation getReturnValue:&transformer];
+			IMP imp = [modelClass methodForSelector:selector];
+			NSValueTransformer*(*function)(id, SEL) = (void *)imp;
+			__unsafe_unretained NSValueTransformer *transformer = function(modelClass, selector);
 
 			if (transformer != nil) result[key] = transformer;
 
@@ -449,13 +445,10 @@ + (NSValueTransformer *)transformerForModelPropertiesOfClass:(Class)modelClass {
 	SEL selector = MTLSelectorWithKeyPattern(NSStringFromClass(modelClass), "JSONTransformer");
 	if (![self respondsToSelector:selector]) return nil;
 
-	NSInvocation *invocation = [NSInvocation invocationWithMethodSignature:[self methodSignatureForSelector:selector]];
-	invocation.target = self;
-	invocation.selector = selector;
-	[invocation invoke];
-
-	__unsafe_unretained id result = nil;
-	[invocation getReturnValue:&result];
+	IMP imp = [self methodForSelector:selector];
+	NSValueTransformer*(*function)(id, SEL) = (void *)imp;
+	__unsafe_unretained NSValueTransformer *result = function(self, selector);
+
 	return result;
 }
 

diff --git a/Mantle/MTLModel+NSCoding.m b/Mantle/MTLModel+NSCoding.m
@@ -128,15 +128,10 @@ - (id)decodeValueForKey:(NSString *)key withCoder:(NSCoder *)coder modelVersion:
 
 	SEL selector = MTLSelectorWithCapitalizedKeyPattern("decode", key, "WithCoder:modelVersion:");
 	if ([self respondsToSelector:selector]) {
-		NSInvocation *invocation = [NSInvocation invocationWithMethodSignature:[self methodSignatureForSelector:selector]];
-		invocation.target = self;
-		invocation.selector = selector;
-		[invocation setArgument:&coder atIndex:2];
-		[invocation setArgument:&modelVersion atIndex:3];
-		[invocation invoke];
-
-		__unsafe_unretained id result = nil;
-		[invocation getReturnValue:&result];
+		IMP imp = [self methodForSelector:selector];
+		id(*function)(id, SEL, id, NSUInteger) = (void *)imp;
+		__unsafe_unretained id result = function(self, selector, coder, modelVersion);
+
 		return result;
 	}
 

diff --git a/Mantle/MTLModel.m b/Mantle/MTLModel.m
@@ -252,12 +252,9 @@ - (void)mergeValueForKey:(NSString *)key fromModel:(NSObject<MTLModel> *)model {
 		return;
 	}
 
-	NSInvocation *invocation = [NSInvocation invocationWithMethodSignature:[self methodSignatureForSelector:selector]];
-	invocation.target = self;
-	invocation.selector = selector;
-
-	[invocation setArgument:&model atIndex:2];
-	[invocation invoke];
+	IMP imp = [self methodForSelector:selector];
+	void(*function)(id, SEL, id) = (void *)imp;
+	function(self, selector, model);
 }
 
 - (void)mergeValuesForKeysFromModel:(id<MTLModel>)model {