Add build script to remove x86_64 and i386 archs from frameworks #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps2
requested changes
Oct 4, 2019
|
Can you describe the issue that this fixes, and steps to test? |
|
This update addresses a failure when creating IPA for distribution. Specifically, when Frameworks contain sim archs (x86_64 and i386), the IPA generation process fails. This update removes the archs when Archiving and IPA generation. There are two ways to test if the issue has been addressed:
|
|
I had the same issue but I was able to export it as ipa as said above |
…t deliverable bolus
This reverts commit f51aed7. Revert
…o ab-remoteCarbsAndBolus merge with LoopKit auto-bolus
…/Loop into ab-remoteCarbsAndBolus resolve conflicts
This reverts commit f51aed7. revert
This reverts commit d90118c. revert
This reverts commit ab73c09. revert
Dev merge with ab otp
This reverts commit 5c341ae. revert
|
merged level with LoopKit dev to fix conflicts |
added 2 commits
April 1, 2020 01:03
|
Close due to bad merge |
dekimsey
added a commit
to dekimsey/Loop
that referenced
this pull request
May 8, 2020
This is an updated apply of PR LoopKit#1126 which addresses the issue reported in LoopKit#1117
dekimsey
added a commit
to dekimsey/Loop
that referenced
this pull request
Jan 4, 2021
This is an updated apply of PR LoopKit#1126 which addresses the issue reported in LoopKit#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Run Script step in Build Phases of the Loop target that removes simulator architectures