This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Let _make_validate method supports the list structures JSON
#18
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 similar comments
debugtalk
reviewed
Feb 2, 2019
| {"eq": ["content.{}".format(key), value]} | ||
| ) | ||
| if isinstance(resp_content_json, dict): | ||
| for key, value in resp_content_json.items(): |
There was a problem hiding this comment.
if isinstance(value, (dict, list)):
continue这一部分还是有必要的，因为假如 value 为 dict/list，已经算是复杂结构体了，保持不变的可能性较小，所以不宜直接将其作为比较项。
debugtalk
reviewed
Feb 2, 2019
| ) | ||
| elif isinstance(resp_content_json, list): | ||
| for i in range(0, len(resp_content_json)): | ||
| resp_content_json = resp_content_json[i] |
There was a problem hiding this comment.
这里有两个问题：
1、重复使用 resp_content_json 这个变量名容易产生混淆，建议对 list 的元素采用不同的变量名；
2、你这里假设 list 始终是 [{a:a},{b:b},...] 的形式，那假如出现 [{a:a},b,...] 的情况就会出现问题。
There was a problem hiding this comment.
是的，想要通用的话，还是要多考虑一下这块，期待后续 validator 支持 jmespath 的语法~~
|
@asdf2014 我先将这个PR关闭了哈，后面会更新为 jmespath 语法。 |
|
@debugtalk 嗯呢，期待下 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.