Skip to content

opentofu 1.6.0-alpha2 (new formula) #149678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2023
Merged

opentofu 1.6.0-alpha2 (new formula) #149678

merged 2 commits into from
Oct 12, 2023

Conversation

b-reich
Copy link
Contributor

@b-reich b-reich commented Oct 5, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

PR ist WIP, opentofu is still in alpha

Sorry, something went wrong.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 5, 2023
@b-reich b-reich changed the title opentofu 1.6.0-alpha1 (new formula) WIP: opentofu 1.6.0-alpha1 (new formula) Oct 5, 2023
@b-reich b-reich marked this pull request as draft October 5, 2023 12:05
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 6, 2023
@p-linnane p-linnane changed the title WIP: opentofu 1.6.0-alpha1 (new formula) opentofu 1.6.0-alpha2 (new formula) Oct 6, 2023
@p-linnane p-linnane marked this pull request as ready for review October 6, 2023 01:23
@p-linnane p-linnane requested a review from a team October 6, 2023 01:23
@Bo98
Copy link
Member

Bo98 commented Oct 6, 2023

We'll probably wait until the first stable unless there's a desperate need for something earlier, but thanks for getting this going!

Comment on lines +16 to +18
# Needs libraries at runtime:
# /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by node)
fails_with gcc: "5"
Copy link
Member

@Bo98 Bo98 Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this about and is it still relevant? Is it shipping a secret node somewhere?

We're an open source package manager that builds from source, and GLIBCXX errors often suggest something prebuilt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from our terraform formula. Not sure if it's still relevant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's because the prebuilt protobuf?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to try and remove it and see if it breaks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but can be after this PR is merged)

@MikeMcQuaid
Copy link
Member

We'll probably wait until the first stable unless there's a desperate need for something earlier

@Bo98 I reckon there kinda is a desperate need at this point and it's a special-case as we'll 100% be packaging the stable release, despite this not having had one yet.

@Bo98
Copy link
Member

Bo98 commented Oct 12, 2023

I don't see how deprecating Terraform is "desperate", and it's not even known if all dependents even support OpenTofu yet given the first alpha release was days ago and it's a separate registry that doesn't have guaranteed uptime yet. But I do agree that I don't have a problem shipping an alpha/beta releases for things that have no stable release so I'm fine with merging if it's needed.

It would however be useful to know if anyone has tested OpenTofu with the dependents we have and if everything works fine, particularly given it seems to be that the "need" here is an immediate mass migration which would be a stable -> alpha switch.

Verified

This commit was signed with the committer’s verified signature.
p-linnane Patrick Linnane
opentofu: update build & livecheck, allow unstable
@MikeMcQuaid
Copy link
Member

I don't see how deprecating Terraform is "desperate",

I don't think it is either but I do think given all the conversation around it right now: it would be more useful to people if this happens at a similar time.

It would however be useful to know if anyone has tested OpenTofu with the dependents we have and if everything works fine

Agreed.

an immediate mass migration which would be a stable -> alpha switch.

That's not going to happen until we've verified everything works fine.

@Bo98
Copy link
Member

Bo98 commented Oct 12, 2023

That's not going to happen until we've verified everything works fine.

Ok, my proposal then is that any form of migration happens in a single PR rather than several, so we don't have half of Homebrew/core use one and the other half use the other. Given the low number of dependents, this should not be a problem in terms of CI time.

@MikeMcQuaid
Copy link
Member

Ok, my proposal then is that any form of migration happens in a single PR rather than several, so we don't have half of Homebrew/core use one and the other half use the other. Given the low number of dependents, this should not be a problem in terms of CI time.

@Bo98 Works for me 👍🏻. CC @chenrui333 @iMichka and any other @Homebrew/maintainers who care about this.

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💯

@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Oct 12, 2023
@github-actions
Copy link
Contributor

Partially verified

This commit is signed with the committer’s verified signature.
BrewTestBot’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 12, 2023
@BrewTestBot BrewTestBot enabled auto-merge October 12, 2023 16:40
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 12, 2023
Merged via the queue into Homebrew:master with commit be93aa0 Oct 12, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants