Skip to content

pool concurrency problem? #664

Closed
Closed
@HiwayChe

Description

@HiwayChe

image

I see the above code in 4db5a3c,
I wonder should reset(object) place before offer(object), if one thread just offer object to pool, another thread immediately obtain it, and reset(object) has not been executed, does it may cause a concurrency problem?

Activity

magro

magro commented on Mar 22, 2019

@magro
Collaborator

Good catch! Do you want to submit a PR?

HiwayChe

HiwayChe commented on Mar 23, 2019

@HiwayChe
Author

No, you do it, it is just a small change.

magro

magro commented on Mar 23, 2019

@magro
Collaborator

I don't know why you don't want to submit a PR (it's a small change as you say), and I don't know why you expect me to do it.

Because you don't pay anything for this piece of software, you cannot expect from anybody to do anything for you.
IMHO OSS lives from contributions. OSS gives you the freedom to improve things that were provided by others on your own - which is a really great thing!

I personally used kryo some years ago and since then try to support it here and there. I do this because I believe in OSS.

I don't expect that you fix the issue you discovered. But reading your words "you do it" makes me sad. Instead, you could have asked me if I could do it, this would be a totally different story. Please try to be nice in this (OSS) world.

isaki

isaki commented on Mar 24, 2019

@isaki
Contributor

It could be a language thing; given the user's profile English is not likely his/her primary tongue and as such, may not have known the connotative difference between "you do it" vs "you can do it", the former being a tad rude to a native English speaker and the latter deferring to you. I read their statement to imply the latter rather than the former.

I could be wrong, of course. I'm just offering an alternative viewpoint in the hopes it makes you feel a bit better.

harrybtlin

harrybtlin commented on Mar 24, 2019

@harrybtlin

English is not his native language

magro

magro commented on Mar 24, 2019

@magro
Collaborator

Thanks for the alternative viewpoint.

HiwayChe

HiwayChe commented on Mar 25, 2019

@HiwayChe
Author

Thanks for the alternative viewpoint.

Sorry, I don't mean to offend you, as english is not my first language, I'll try to improve my english.

HiwayChe

HiwayChe commented on Mar 25, 2019

@HiwayChe
Author

..., emm, just close this issue by misoperation, reopen it.

julien-may

julien-may commented on Apr 1, 2019

@julien-may
Contributor

What's the state here? If no one's doing it, I am glad to do the fix.

magro

magro commented on Apr 1, 2019

@magro
Collaborator

@julien-may great if you'd take care of it.

julien-may

julien-may commented on Apr 1, 2019

@julien-may
Contributor

here you go: #665

magro

magro commented on Apr 1, 2019

@magro
Collaborator

Thanks!

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @magro@julien-may@HiwayChe@isaki@harrybtlin

        Issue actions

          pool concurrency problem? · Issue #664 · EsotericSoftware/kryo