Fix undefined __pthread_mutex_lock/unlock for glibc 2.34+/DISABLE_HERMETIC_BUILD #34771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
…METIC_BUILD
Right now it fails with:
ld.lld: error: undefined symbol: __pthread_mutex_lock
>>> referenced by ThreadFuzzer.cpp:300 (./src/Common/ThreadFuzzer.cpp:300)
>>> src/CMakeFiles/clickhouse_common_io.dir/Common/ThreadFuzzer.cpp.o:(pthread_mutex_lock)
>>> did you mean: __pthread_mutex_lock@GLIBC_2.2.5
>>> defined in: /usr/lib/libc.so.6
Here is the list of matched symbols for 2.35:
$ nm -D /lib/libc.so.6 | fgrep pthread_mutex_lock
00000000000908a0 T __pthread_mutex_lock@GLIBC_2.2.5
00000000000908a0 T pthread_mutex_lock@@GLIBC_2.2.5
$ nm -D /lib/libpthread.so.0 | fgrep -c pthread_mutex_lock
0
And this is for 2.33:
$ nm -D /lib/x86_64-linux-gnu/libc.so.6 | fgrep pthread_mutex_lock
0000000000083eb0 T pthread_mutex_lock@@GLIBC_2.2.5
$ nm -D /lib/x86_64-linux-gnu/libpthread.so.0 | fgrep pthread_mutex_lock
000000000000af00 T __pthread_mutex_lock@@GLIBC_2.2.5
000000000000af00 W pthread_mutex_lock@@GLIBC_2.2.5
Because "likely" starting from 27a448223cb2d3bab191c61303db48cee66f871c
("nptl: Move core mutex functions into libc") [1], __pthread_mutex_lock
is not exported anymore.
[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=27a448223cb2d3bab191c61303db48cee66f871c
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
fix-glibc2.34-build
branch
from
47f77f3
to
9b749ae
Compare
|
@alexey-milovidov friendly ping |
alexey-milovidov
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it fails with:
Here is the list of matched symbols for 2.35:
And this is for 2.33:
Because "likely" starting from 27a448223cb2d3bab191c61303db48cee66f871c
("nptl: Move core mutex functions into libc") 1, __pthread_mutex_lock
is not exported anymore.
Changelog category (leave one):