Parallel final #10463
Merged
Parallel final #10463
+648
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochetovNicolai
force-pushed
the
parallel-final
branch
from
886f91f to
ecbdbed
Compare
KochetovNicolai
force-pushed
the
parallel-final
branch
from
ecbdbed to
19dadb8
Compare
| throw Exception("Method transform is not implemented for " + getName(), ErrorCodes::NOT_IMPLEMENTED); | ||
| } | ||
|
|
||
| virtual void transform(Chunk & input_chunk, Chunk & output_chunk) |
alexey-milovidov
requested changes
May 17, 2020
| { | ||
| public: | ||
| AddingSelectorTransform(const Block & header, size_t num_outputs_, ColumnNumbers key_columns_); | ||
| String getName() const override { return "SplittingByHash"; } |
alexey-milovidov
added
the
st-waiting-for-fix
alexey-milovidov
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Selects with final are executed in parallel. Added setting
max_final_threadsto limit the number of threads used.