This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Remove conflicting nullable specifier on init #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nullable specifier on init conflicts with the nonnull specifier on NSObject which generates a warning. This change removes it and throws an exception if init is used.
Codecov Report
@@ Coverage Diff @@
## master #4182 +/- ##
==========================================
- Coverage 87.74% 86.91% -0.84%
==========================================
Files 46 46
Lines 5730 6031 +301
Branches 294 332 +38
==========================================
+ Hits 5028 5242 +214
- Misses 702 789 +87
Continue to review full report at Codecov.
|
|
Thanks for looking at it, @SlaunchaMan, albeit I can't see what's the issue about simply merging either #4163 or #4154. [edit: ah OK, it was because Travis CI builds were previously broken on Master, so all Pull Requests were failing the test as well] |
|
Yep, just trying to get the build bot happy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4154—this is just cherry-picking it onto
master. Closes #4163. Closes #4154.