This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Add XMLParser/XMLDocument serializer tests #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyline75489
commented
Oct 14, 2016
| @@ -166,7 +166,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| - (instancetype)init; | |||
|
|
|||
| /** | |||
| Input and output options specifically intended for `NSXMLDocument` objects. For possible values, see the `NSJSONSerialization` documentation section "NSJSONReadingOptions". `0` by default. | |||
| Input and output options specifically intended for `NSXMLDocument` objects. For possible values, see the `NSXMLDocument` documentation section "Input and Output Options". `0` by default. | |||
There was a problem hiding this comment.
This looks like a copy-and-paste error for me.
Codecov Report
@@ Coverage Diff @@
## master #3753 +/- ##
==========================================
+ Coverage 86.95% 87.23% +0.27%
==========================================
Files 45 46 +1
Lines 5505 5539 +34
Branches 439 439
==========================================
+ Hits 4787 4832 +45
+ Misses 715 704 -11
Partials 3 3
Continue to review full report at Codecov.
|
SlaunchaMan
approved these changes
Jul 13, 2017
|
@SlaunchaMan Would you mind merging this PR & #3750 which were drafted a long time ago |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by 290ec35, this adds tests for
AFXMLParserResponseSerializerandAFXMLDocumentResponseSerializer. This also fixes an error inAFXMLDocumentResponseSerializerdocumentation.