This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Enable custom httpbin URL with HTTPBIN_BASE_URL environment variable #3748
+42
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to install that during the CI script to speed up the test suite? I'm assuming the test suite runs faster? |
|
No, because it's running on http instead of https and thus breaking some tests. I tried to run it on https some time ago but failed. I’m not sure it would even be possible to get a valid certificate for 127.0.0.1 without a domain name. |
|
Ah good point. Didn't think about that. |
Editing the scheme and checking the `HTTPBIN_BASE_URL` box enables running the test suites on a default local installation of httpbin.
0xced
force-pushed
the
httpbin-base-url
branch
from
2b70766 to
5d6867c
Compare
Current coverage is 87.48% (diff: 100%)@@ master #3748 diff @@
==========================================
Files 45 45
Lines 6234 6235 +1
Methods 1101 1101
Messages 0 0
Branches 415 415
==========================================
+ Hits 5454 5455 +1
Misses 777 777
Partials 3 3
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing the scheme and checking the
HTTPBIN_BASE_URLbox enables running the test suites on a default local installation of httpbin.