This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixed crash when passing invalid JSON to request serialization #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.50% (diff: 100%)@@ master #3719 diff @@
==========================================
Files 45 45
Lines 6224 6240 +16
Methods 1099 1100 +1
Messages 0 0
Branches 414 416 +2
==========================================
+ Hits 5445 5460 +15
- Misses 776 777 +1
Partials 3 3
|
|
Could you rebase this with master to get Xcode 8 test support? |
0xced
force-pushed
the
fix-invalid-json-serialization-crash
branch
from
2f4ed66
to
27c755b
Compare
|
Rebased. |
kcharwood
changed the title
|
@0xced can you resolve the conflict? |
|
Of course. Will do later today. |
Fixes #3711
The `NSURLErrorCannotDecodeContentData` code is not ideal, but `AFURLRequestSerializationErrorDomain` should define its own error codes anyway.
0xced
force-pushed
the
fix-invalid-json-serialization-crash
branch
from
27c755b
to
e2232e3
Compare
kcharwood
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3711
The
NSURLErrorCannotDecodeContentDatacode is not ideal, butAFURLRequestSerializationErrorDomainshould define its own error codes anyway.