Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Updates AFHTTPSessionManager documentation to reflect v3.x changes #3476

Conversation

ecaselles
Copy link
Contributor

@ecaselles ecaselles commented Apr 28, 2016

This closes #3412.

The documentation on AFHTTPSessionManager, Methods to Override section states that...

To change the behavior of all data task operation construction, which is also used in the GET / POST / et al. convenience methods, override dataTaskWithRequest:completionHandler:

But that is no longer accurate, since these convenience methods now go through the new
dataTaskWithRequest:uploadProgress:downloadProgress:completionHandler:. Therefore, overriding dataTaskWithRequest:completionHandler: will have no effect since it will never be called.

This PR updates the documentation to reflect the fact that the method to override is now dataTaskWithRequest:uploadProgress:downloadProgress:completionHandler:.

@ecaselles ecaselles changed the title Updates AFHTTPSessionManager documentation to reflect latest changes Updates AFHTTPSessionManager documentation to reflect v3.x changes Apr 28, 2016
@kcharwood kcharwood added this to the 3.1.1 milestone May 6, 2016
@kcharwood
Copy link
Contributor

Thanks!

@kcharwood kcharwood merged commit e1e2d62 into AFNetworking:master May 6, 2016
@kcharwood kcharwood modified the milestones: 3.1.1, 3.2.0 Oct 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants