Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Use NSKeyValueChangeNewKey constant in change dictionary rather than hardcoded string. #3360

Merged
merged 1 commit into from Mar 14, 2016

Conversation

jasonhotsauce
Copy link

  • We explicitly used @"new" in change, I think it's better to use
    platform defined constant.

This is a duplicate one for PR#3352. My repository was messed up during the weekend and the PR was closed.

@codecov-io
Copy link

Current coverage is 76.35%

Merging #3360 into master will increase coverage by +0.20% as of 68562bb

@@            master   #3360   diff @@
======================================
  Files            5       5       
  Stmts         2491    2491       
  Branches         0       0       
  Methods                          
======================================
+ Hit           1897    1902     +5
  Partial          0       0       
+ Missed         594     589     -5

Review entire Coverage Diff as of 68562bb

Powered by Codecov. Updated on successful CI builds.

@kcharwood kcharwood added this to the 3.1.0 milestone Mar 14, 2016
@kcharwood
Copy link
Contributor

Thanks @jasonhotsauce!

Could you backmerge/rebase with master so we can get tests passing on this branch?

🍻

After that, I will merge it in.

@kcharwood kcharwood changed the title Use NSKeyValueChangeNewKey in change dictionary. Use NSKeyValueChangeNewKey constant in change dictionary rather than hardcoded string. Mar 14, 2016
* We explicitly used @"new" in `change`, I think it's better to use
platform defined constant.
@jasonhotsauce
Copy link
Author

@kcharwood 👍 Done. Thanks.

kcharwood added a commit that referenced this pull request Mar 14, 2016
Use `NSKeyValueChangeNewKey` constant in change dictionary rather than hardcoded string.
@kcharwood kcharwood merged commit 5d1dc7c into AFNetworking:master Mar 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants