Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Resolved compiler warnings for documentation errors #3336

Merged

Conversation

ricsantos
Copy link
Contributor

These compiler warnings for incorrect parameters in the function documentation don't seem to appear when building AFNetworking, but they do appear in an iOS project I use with AFNetworking as a dependency (via Pods).

afnetworking_compiler_warnings

@kcharwood
Copy link
Contributor

Thanks so much! Would you be able to rebase this with master so the tests pass?

Thanks!

@kcharwood kcharwood added this to the 3.1.0 milestone Feb 15, 2016
@ricsantos ricsantos force-pushed the resolve_compiler_warnings branch 2 times, most recently from 4f3bee7 to 474cbfd Compare February 15, 2016 23:05
@codecov-io
Copy link

Current coverage is 74.55%

Merging #3336 into master will increase coverage by +0.17% as of 0c3cec1

@@            master   #3336   diff @@
======================================
  Files            5       5       
  Stmts         3002    3002       
  Branches         0       0       
  Methods                          
======================================
+ Hit           2233    2238     +5
  Partial          0       0       
+ Missed         769     764     -5

Review entire Coverage Diff as of 0c3cec1

Powered by Codecov. Updated on successful CI builds.

@ricsantos
Copy link
Contributor Author

Yay! Rebased and now all checks have passed.

@kcharwood kcharwood changed the title Resolved compiler warnings Resolved compiler warnings for documentation errors Mar 14, 2016
kcharwood added a commit that referenced this pull request Mar 14, 2016
Resolved compiler warnings for documentation errors
@kcharwood kcharwood merged commit 502fe0f into AFNetworking:master Mar 14, 2016
@kcharwood
Copy link
Contributor

🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants