Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fixed static analyzer warnings on AFNetworkReachabilityManager #3315

Merged
merged 2 commits into from Jan 28, 2016
Merged

Fixed static analyzer warnings on AFNetworkReachabilityManager #3315

merged 2 commits into from Jan 28, 2016

Conversation

SlaunchaMan
Copy link
Contributor

The current version of AFNetworkReachabilityManager fixes some static analyzer warnings by using #ifndef __clang_analyzer__ to hide the errors. This PR removes that conditional code in favor of fixing the analyzer issue.

Instead of bridging the reachability reference to ARC, this PR sets the type of networkReachability to SCNetworkReachabilityRef, which not only allows for cleaner memory management as far as the analyzer is concerned, but also gets rid of a lot of unnecessary bridging further into the file.

@kcharwood
Copy link
Contributor

Could you sync this back up with master to get the fixes for the expired certificate? That should allow the test suite to pass.

@SlaunchaMan
Copy link
Contributor Author

Rebased!

@SlaunchaMan SlaunchaMan reopened this Jan 28, 2016
@codecov-io
Copy link

Current coverage is 74.31%

Merging #3315 into master will decrease coverage by -0.07% as of f41426a

@@            master   #3315   diff @@
======================================
  Files            5       5       
  Stmts         3002    3002       
  Branches         0       0       
  Methods                  0       
======================================
- Hit           2233    2231     -2
  Partial          0       0       
- Missed         769     771     +2

Review entire Coverage Diff as of f41426a

Powered by Codecov. Updated on successful CI builds.

@kcharwood kcharwood added this to the 3.1.0 milestone Jan 28, 2016
@kcharwood
Copy link
Contributor

Thanks!

@kcharwood kcharwood changed the title Fix static analyzer warnings on AFNetworkReachabilityManager Fixed static analyzer warnings on AFNetworkReachabilityManager Jan 28, 2016
kcharwood added a commit that referenced this pull request Jan 28, 2016
Fixed static analyzer warnings on AFNetworkReachabilityManager
@kcharwood kcharwood merged commit c7f8d01 into AFNetworking:master Jan 28, 2016
@SlaunchaMan SlaunchaMan deleted the fix-reachability-warnings branch January 29, 2016 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants