This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixed static analyzer warnings on AFNetworkReachabilityManager #3315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
AFNetworkReachabilityManager
fixes some static analyzer warnings by using#ifndef __clang_analyzer__
to hide the errors. This PR removes that conditional code in favor of fixing the analyzer issue.Instead of bridging the reachability reference to ARC, this PR sets the type of
networkReachability
toSCNetworkReachabilityRef
, which not only allows for cleaner memory management as far as the analyzer is concerned, but also gets rid of a lot of unnecessary bridging further into the file.