Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fixed issue where download progress would not be reported in iOS 7 #3294

Merged
merged 1 commit into from Jan 15, 2016

Conversation

emilyZhouwm
Copy link

iOS8.0, 9.0 is OK, but progress block not called at all,iOS7.0 #3282

@codecov-io
Copy link

Current coverage is 74.28%

Merging #3294 into master will increase coverage by +0.07% as of 30a4713

@@            master   #3294   diff @@
======================================
  Files            5       5       
  Stmts         3002    3002       
  Branches         0       0       
  Methods                          
======================================
+ Hit           2228    2230     +2
  Partial          0       0       
+ Missed         774     772     -2

Review entire Coverage Diff as of 30a4713

Powered by Codecov. Updated on successful CI builds.

@kcharwood kcharwood changed the title for iOS7 call downloadProgress block Fixed issue where download progress would not be reported in iOS 7 Jan 15, 2016
@kcharwood kcharwood added this to the 3.1.0 milestone Jan 15, 2016
@kcharwood
Copy link
Contributor

Thanks for tracking this down @emilyZhouwm.

I didn't think about iOS 7 impact, but given the class cluster implementation that differs in iOS 7, its not surprising this is needed. I wish we had an iOS 7 test target to verify this fix, but unfortunately we do not :(.

Thanks!

kcharwood added a commit that referenced this pull request Jan 15, 2016
Fixed issue where download progress would not be reported in iOS 7
@kcharwood kcharwood merged commit aa9b5f5 into AFNetworking:master Jan 15, 2016
@emilyZhouwm
Copy link
Author

^_^We adapted to the minimum to iOS7, so will test the equipment retained iOS7 and iOS8 ipod touch operating system.Now is only 10% of users inside iOS7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants