This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Removed workaround for NSJSONSerialization bug that was fixed in iOS 7 #3253
+25
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
0xced
force-pushed
the
remove-NSJSONSerialization-workaround
branch
from
adbeccc to
3b5c4e8
Compare
|
For reference, this workaround was introduced in #660. |
The NSJSONSerialization bug with Unicode character escape codes has been fixed in iOS 7, see http://openradar.appspot.com/radar?id=2397401#ag9zfm9wZW5yYWRhci1ocmRyFAsSB0NvbW1lbnQYgICAgIDdwwgM Removing the NSData -> NSString -> NSData roundtrip is also likely a nice performance boost.
0xced
force-pushed
the
remove-NSJSONSerialization-workaround
branch
from
3b5c4e8 to
00e7a8b
Compare
kcharwood
changed the title
kcharwood
added a commit
that referenced
this pull request
Jan 5, 2016
…ound Removed workaround for NSJSONSerialization bug that was fixed in iOS 7
|
🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NSJSONSerialization bug with Unicode character escape codes has been fixed in iOS 7, see http://openradar.appspot.com/radar?id=2397401#ag9zfm9wZW5yYWRhci1ocmRyFAsSB0NvbW1lbnQYgICAgIDdwwgM
Removing the NSData -> NSString -> NSData roundtrip is also likely a nice performance boost.