This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixed AFImageResponseSerializer serialization macros on watchOS and tvOS
#3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as well as a couple other missing preprocessor checks for tvOS and watchOS.
Current coverage is
|
| @@ -747,7 +747,7 @@ - (void)encodeWithCoder:(NSCoder *)coder { | |||
| - (instancetype)copyWithZone:(NSZone *)zone { | |||
| AFImageResponseSerializer *serializer = [[[self class] allocWithZone:zone] init]; | |||
|
|
|||
| #if TARGET_OS_IOS || TARGET_OS_TV | |||
| #if TARGET_OS_IOS || TARGET_OS_TV | TARGET_OS_WATCH | |||
|
I wish Apple gave us a watchOS test target! Thanks. I left a comment on one issue to fix, and then I'll get this merged in. 🍻 |
kcharwood
changed the title
AFImageResponseSerializer serializing on watchOS
|
Whoops, good catch 🙂 |
|
@lessthanyouthink Could you push up a fix for that typo? After that, I'll get it merged in. |
|
Sorry about the delay, I was waiting until I got back in front of my main computer. Done! |
kcharwood
added a commit
that referenced
this pull request
Dec 16, 2015
…onse-serialization Fixed `AFImageResponseSerializer` serializing on watchOS
|
Thanks 🍻 |
kcharwood
changed the title
AFImageResponseSerializer serializing on watchOS AFImageResponseSerializer serialization macros on watchOS and tvOS
lessthanyouthink
deleted the
fix-watchOS-image-response-serialization
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as well as a couple other missing preprocessor checks for tvOS and watchOS in that class. See: https://github.com/AFNetworking/AFNetworking/issues/3228