Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fixed race condition with ImageView/Button image downloading when starting/cancelling/starting the same request #3215

Merged
merged 1 commit into from Dec 11, 2015
Merged

Fixed race condition with ImageView/Button image downloading when starting/cancelling/starting the same request #3215

merged 1 commit into from Dec 11, 2015

Conversation

kcharwood
Copy link
Contributor

Alternate Solution for #3214

See Alamofire/AlamofireImage#55 for details

@cnoon which one do you think is better? I think I like approach better, but it does add a new API method to the downloader. Should still be backwards compatible.

@kcharwood kcharwood added this to the 3.0.1 milestone Dec 11, 2015
@kcharwood kcharwood mentioned this pull request Dec 11, 2015
Closed
@codecov-io
Copy link

Current coverage is 65.63%

Merging #3215 into master will decrease coverage by -0.33% as of cdb8c87

@@            master   #3215   diff @@
======================================
  Files            5       5       
  Stmts         2415    2415       
  Branches         0       0       
  Methods          0               
======================================
- Hit           1593    1585     -8
  Partial          0       0       
- Missed         822     830     +8

Review entire Coverage Diff as of cdb8c87

Powered by Codecov. Updated on successful CI builds.

@cnoon
Copy link
Member

cnoon commented Dec 11, 2015

Yeah buddy...definitely a more scalable approach. It also solves the problem of having to pass the RequestReceipt to the completion closure to validate the receiptID. 👍🏼

@kcharwood kcharwood changed the title [Alternate] Fixed race condition with image downloader when starting/cancelling/starting the same request Fixed race condition with image downloader when starting/cancelling/starting the same request Dec 11, 2015
@kcharwood kcharwood changed the title Fixed race condition with image downloader when starting/cancelling/starting the same request Fixed race condition with ImageView/Button image downloading when starting/cancelling/starting the same request Dec 11, 2015
kcharwood added a commit that referenced this pull request Dec 11, 2015
@kcharwood
Merge pull request #3215 from AFNetworking/bug/image_view_race_condit…
1fec924 
…ion_alternate_fix

Fixed race condition with ImageView/Button image downloading when starting/cancelling/starting the same request
@kcharwood kcharwood merged commit 1fec924 into master Dec 11, 2015
@kcharwood kcharwood deleted the bug/image_view_race_condition_alternate_fix branch December 11, 2015 17:54
kcharwood added a commit that referenced this pull request Dec 11, 2015
@kcharwood
Added an additional test for #3215
9185889
@kcharwood kcharwood added fixed and removed changed labels Dec 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fixed uikit extensions
Projects
None yet
Milestone
3.0.1
3 participants
@kcharwood @codecov-io @cnoon