This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Changed pinnedCertificates type in AFSecurityPolicy from NSArray to NSSet
#3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinned certificates were deduplicated anyway, so let’s make it clear directly in the API.
|
Although this should not impact v2 to v3 migration, this should probably be mentioned somewhere. What’s the best place, the CHANGELOG or the wiki? |
|
Now seems like a great time to do this. Both the Changelog and the wiki would be a good place to include this. |
kcharwood
changed the title
pinnedCertificates type in AFSecurityPolicy from NSArray to NSSet
kcharwood
added a commit
that referenced
this pull request
Nov 18, 2015
Changed `pinnedCertificates` type in `AFSecurityPolicy` from `NSArray` to `NSSet`
|
The issue will automatically get created in the Changelog, but I still need to update the wiki. Thanks again! 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned certificates were deduplicated anyway, so let’s make it clear directly in the API.