This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Added a initial delay to the network indicator per the Apple HIG #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… activity indicator
| - (void)startActivationDelayTimer { | ||
| self.activationDelayTimer = [NSTimer | ||
| timerWithTimeInterval:self.activationDelay target:self selector:@selector(activationDelayTimerFired) userInfo:nil repeats:NO]; | ||
| [[NSRunLoop mainRunLoop] addTimer:self.activationDelayTimer forMode:NSRunLoopCommonModes]; |
There was a problem hiding this comment.
You probably want to add the timers to the UITrackingRunLoopMode mode as well for iOS targets. Otherwise you won't get called back when scrolling which is probably not what you want.
|
Overall I think this looks really good @kcharwood. Once you figure out what you'd like to do with the comments I pointed out, you've got a thumbs up from me. 👍🏼 |
- Refactored test class to begin using common timeout across all classes
|
Test failing due to unrelated issue. Will address those in another PR. |
kcharwood
added a commit
that referenced
this pull request
Oct 26, 2015
…ty_delay A refactored version of #3086 allowing a delayed start to the network activity indicator
kcharwood
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to support the recommendation from the Apple HIG, which is short requests that last less than a couple of seconds should not trigger the network activity indicator.
Originally brought up in #3086 by @lubiluk
cc @cnoon @kylef @jshier for review.