Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Tweaks to project to support Framework Project #3062

Merged
merged 7 commits into from Oct 15, 2015

Conversation

cnoon
Copy link
Member

@cnoon cnoon commented Oct 15, 2015

Dug through the new 3.0.0 structure and found a few things that could be condensed or unified. I tried to split each change out into a separate commit to make it easier to see what changes I actually made.

The only callout I have is that I changed the deployment target in the project on iOS to 8.0 to help the compiler out to generate non-compatible changes. However, the podspec is still supporting iOS 7.0 as a deployment target. Does CocoaPods handle the difference between 7 and 8 support for frameworks properly? I'm assuming it does, but wanted to ask. I've spent so much time in Swift over the last year, I'm not even sure how this works for Obj-C libraries.

@cnoon cnoon added this to the 3.0.0 milestone Oct 15, 2015
@cnoon
Copy link
Member Author

cnoon commented Oct 15, 2015

cc @kcharwood and @kylef

@cnoon
Copy link
Member Author

cnoon commented Oct 15, 2015

@kcharwood I also changed the release version from 3.0.0-beta0 to 3.0.0-beta.1 to follow the Alamofire convention. If you'd prefer the syntax you used, then that's perfectly fine too. Just though I'd throw in a commit to unify our approach if you wanted.

@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'AFNetworking'
s.version = '3.0.0'
s.version = '3.0.0-beta.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry, too late in the day. Mistaken AFNetworking for Alamofire.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sleep my man...sleep! 💤😉

@tomtaylor
Copy link

I'm having trouble building using Carthage on 122f1b2, using Xcode 7.0.1.

*** Building scheme "AFNetworking tvOS" in AFNetworking.xcworkspace
xcodebuild: error: Failed to build workspace AFNetworking with scheme AFNetworking tvOS.
    Reason: The run destination My Mac is not valid for Running the scheme 'AFNetworking tvOS'.
A shell task failed with exit code 70:
xcodebuild: error: Failed to build workspace AFNetworking with scheme AFNetworking tvOS.
    Reason: The run destination My Mac is not valid for Running the scheme 'AFNetworking tvOS'.

@tomtaylor
Copy link

Ignore this - I've realised that it's trying to build the tvOS target, but the SDK isn't provided on Xcode 7.0. Building with --platform iOS bypasses this.

@kcharwood
Copy link
Contributor

Thanks @cnoon. These all look good to me! 🍻

I'm also cool with the version name change.

kcharwood added a commit that referenced this pull request Oct 15, 2015
…e_tweaks

Project - Framework Structure Tweaks
@kcharwood kcharwood merged commit 945f976 into 3_0_0_branch Oct 15, 2015
@kcharwood kcharwood deleted the project/framework_structure_tweaks branch October 15, 2015 13:08
@kcharwood kcharwood changed the title Project - Framework Structure Tweaks Tweaks to project to support Framework Project Nov 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants