This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Added missing __nullable attributes to failure blocks in AFHTTPRequestOperationManager and AFHTTPSessionManager
#3057
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hoppenichu. Under what conditions do you see those come back as nil? I'd like to add tests if possible, and make sure the documentation is up to date. |
|
@kcharwood In case request serialization failed and could not create |
|
Ah you're right! I totally missed that looking over that code. I'll get this patch in! Thanks 🍻 |
|
Added unit test and merged in 2.x with c90c3da |
kcharwood
added a commit
that referenced
this pull request
Oct 21, 2015
|
Merged in 3.0.0 with 9200627 |
|
🍻 |
|
👍 |
kcharwood
changed the title
AFHTTPRequestOperationManager and AFHTTPSessionManager
sergiou87
pushed a commit
to plexinc/AFNetworking
that referenced
this pull request
Dec 12, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled