This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Add '__nullable' to response attribute #3000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'__nullable' needs to be added to the response attribute in the success block.
'__nullable' needs to be added to the response attribute in the success block since we are returning nil via [success(urlRequest, nil, cachedImage);]
'__nullable' needs to be added to the id attribute to allow for the passing of nil for the image cache. This was found during testing.
'__nullable' needs to be added to the id attribute to allow for the passing of nil for the image cache. This was found during testing.
|
Thanks @dppeak. Could you squash this down into one commit? |
|
I took these changes in 1bfb849, and updated the UIButton category as well. Thanks! 🍻 |
|
Glad I could help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add '__nullable' to the response attribute of the success block in the setImageWithURLRequest method.