Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Add '__nullable' to response attribute #3000

Closed
wants to merge 4 commits into from

Conversation

dppeak
Copy link

@dppeak dppeak commented Sep 22, 2015

Need to add '__nullable' to the response attribute of the success block in the setImageWithURLRequest method.

'__nullable' needs to be added to the response attribute in the success block.
'__nullable' needs to be added to the response attribute in the success block since we are returning nil via [success(urlRequest, nil, cachedImage);]
'__nullable' needs to be added to the id attribute to allow for the passing of nil for the image cache.  This was found during testing.
'__nullable' needs to be added to the id attribute to allow for the passing of nil for the image cache.  This was found during testing.
@kcharwood
Copy link
Contributor

Thanks @dppeak. Could you squash this down into one commit?

@kcharwood kcharwood added this to the 2.6.1 milestone Sep 30, 2015
@kcharwood
Copy link
Contributor

I took these changes in 1bfb849, and updated the UIButton category as well.

Thanks! 🍻

@kcharwood kcharwood closed this Oct 1, 2015
@dppeak
Copy link
Author

dppeak commented Oct 1, 2015

Glad I could help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants