Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Convert query escapes to stringByAddingPercentEncodingWithAllowedCharacters #2908

Merged
merged 1 commit into from Aug 19, 2015
Merged

Convert query escapes to stringByAddingPercentEncodingWithAllowedCharacters #2908

merged 1 commit into from Aug 19, 2015

Conversation

kcharwood
Copy link
Contributor

Since watchOS requires us to use stringByAddingPercentEncodingWithAllowedCharacters, we've migrated over to that. We're also using the logic that has been baked in to AlamoFire.

Note this does have one backwards compatible issue. / and ? are no longer encoded in the query parameters, per RFC 3986.

 In RFC 3986 - Section 3.4, it states that the "?" and "/" characters should not be escaped to allow
 query strings to include a URL. Therefore, all "reserved" characters with the exception of "?" and "/"
 should be percent-escaped in the query string.
    - parameter string: The string to be percent-escaped.
    - returns: The percent-escaped string.

@cnoon want to take a look?

@kcharwood kcharwood added this to the 2.6.0 milestone Aug 19, 2015
@cnoon
Copy link
Member

cnoon commented Aug 19, 2015

This looks good to me dude! 👍🏼

kcharwood added a commit that referenced this pull request Aug 19, 2015
@kcharwood
Merge pull request #2908 from AFNetworking/url_query_parameter_encodi…
2cf77ad 
…ng_update

Convert query escapes to `stringByAddingPercentEncodingWithAllowedCharacters`
@kcharwood kcharwood merged commit 2cf77ad into master Aug 19, 2015
shawnjk pushed a commit to toopher/BDBOAuth1Manager that referenced this pull request Sep 1, 2015
URL encode / and ? in the query string
2e7ba2c 
AFNetworking 2.6 removed those characters from its encoded character
list. See AFNetworking/AFNetworking#2908
shawnjk pushed a commit to shawnjk/BDBOAuth1Manager that referenced this pull request Sep 1, 2015
URL encode / and ? in the query string
09c99bc 
AFNetworking 2.6 removed those characters from its encoded character
list. See AFNetworking/AFNetworking#2908
@shawnjk shawnjk mentioned this pull request Sep 1, 2015
Merged
bdbergeron pushed a commit to bdbergeron/BDBOAuth1Manager that referenced this pull request Sep 23, 2015
@bdbergeron
URL encode / and ? in the query string
f4288a8 
AFNetworking 2.6 removed those characters from its encoded character
list. See AFNetworking/AFNetworking#2908
@onmyway133
Copy link

It would be better if we can have a flag for that :)

@kcharwood kcharwood deleted the url_query_parameter_encoding_update branch October 19, 2015 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
request serializers
Projects
None yet
Milestone
2.6.0
3 participants
@kcharwood @cnoon @onmyway133