This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix #2864: allow empty x-www-form-urlencoded bodies #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to add tests demonstrating the fix? |
|
@kcharwood done |
|
@kcharwood: sorry if it sounds pushy, which is not my intent, but could you let me know what is blocking the merging of this PR (it's blocking an internal ticket we have here at my workplace, which is getting carried over to new sprints as they come in)? If it's just a lack of time, then no big deal :) Cheers |
|
Hey @jcayzac In Xcode 7, this is generating a warning: |
|
Hi @kcharwood! Interesting! Oh well, I removed it and replaced it with a good old |
kcharwood
added a commit
that referenced
this pull request
Oct 8, 2015
Fix #2864: allow empty x-www-form-urlencoded bodies
|
Sorry for the delay on getting this one. Thanks for the PR! 🍻 |
|
Updated in 3.0.0 with 9521690 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.