This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Removed Certificate Chain Validation #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. |
There was a problem hiding this comment.
We probably don't want to change the copyright header do we?
There was a problem hiding this comment.
Good catch. By product of creating a new file for the new tests, then blasting the old one upon completion. I'll add it back.
kcharwood
force-pushed
the
simplified_security
branch
2 times, most recently
from
9154fde
to
6e3c41d
Compare
- Refactored Security Tests - Updated Documentation
kcharwood
force-pushed
the
simplified_security
branch
from
6e3c41d
to
c2c0f94
Compare
|
Going once.... Going Twice... |
kcharwood
added a commit
that referenced
this pull request
Jul 27, 2015
Removed Certificate Chain Validation
|
Hi, when allowing invalid certificates, why do we need to pin the certificate only if validatesDomainName is true? There's no mention about domain name validation in Apple Docs referenced in this change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2744, I have removed certificate chain validation as a feature in
AFSecurityPolicy. After a community discussion as well as a conversation with the security team at Apple, there are no specific advantages to maintaining this feature going forward.Starting with this pull request, a security policy will allow a server trust if any of the pinned certificates meeting the security requirements of the policy.
In addition, I have completely refactored the security policy tests, and grouped them in a way that is more readable and more maintainable going forward. I would love some eyes on those tests and see if we can come up with any more, especially negative test cases.
We'll get this in first, then move on to bringing in public key hash pinning.