This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Provide URL request to the success block when images are retrieved from cache #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @chrisgibbs. I think this makes sense. I'd like to see a test added to verify the behavior going forward. |
added 3 commits
June 5, 2015 10:50
…e success block when images are fetched from cache
| setImageWithURLRequest:self.cachedImageRequest | ||
| placeholderImage:nil | ||
| success:^(NSURLRequest *request, NSHTTPURLResponse *response, UIImage *image) { | ||
| XCTAssertEqual(request, weakSelf.cachedImageRequest, @"URL requests do not match"); |
There was a problem hiding this comment.
Should we assert that the response IS nil? I believe that is what indicates the image returned from cache, right?
There was a problem hiding this comment.
Sounds reasonable. I'll make sure that's documented as well.
kcharwood
added a commit
that referenced
this pull request
Jul 24, 2015
…param Provide URL request to the success block when images are retrieved from cache
|
All tests pass locally. Thanks for the PR! 🍻 Note I'll want to make sure this behavior change is explicitly called out in the Release Notes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UIImageView+AFNetworking successfully retrieves an image from the cache, the URL request was not being provided to the success block along with the image. This meant that there was no way to compare retrieved image's URL with the URL that should be displayed.