Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

problem with baseURL #2761

Merged
merged 1 commit into from
Jul 24, 2015
Merged

problem with baseURL #2761

merged 1 commit into from
Jul 24, 2015
+1 −1

Conversation

kcharwood
Copy link
Contributor 

/**
 The URL used to monitor reachability, and construct requests from relative paths in methods like `requestWithMethod:URLString:parameters:`, and the `GET` / `POST` / et al. convenience methods.
 */
@property (readonly, nonatomic, strong) NSURL *baseURL;

In the - (instancetype)initWithBaseURL:(NSURL *) method, self.reachabilityManager doesn't use the baseURL. I know I can adjust self.reachabilityManager later with "initWithReachability. But the description confused me. Is this a problem?

@kcharwood kcharwood added this to the 2.5.5 milestone Jun 2, 2015
@kcharwood
Copy link
Contributor

That does appear to be an issue. I'll chase this one down. Thanks for calling this out.

@kcharwood kcharwood modified the milestones: 2.5.5, 2.6.0 Jun 26, 2015
@kcharwood
Updated documentation to remove reachability manager reference that i…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9fdd365 
…s not used
kcharwood added a commit that referenced this pull request Jul 24, 2015
@kcharwood
Merge pull request #2761 from AFNetworking/2761
09a3b74 
problem with baseURL
@kcharwood kcharwood merged commit 09a3b74 into master Jul 24, 2015
@kcharwood
Copy link
Contributor

Thanks!

🍻

@kcharwood kcharwood deleted the 2761 branch July 24, 2015 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation reachability
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kcharwood