This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Eliminated duplicated pinned certificates #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,6 +237,39 @@ - (void)testPublicKeyPinningFailsForHTTPBinOrgIfNoCertificateIsPinned { | |||
| CFRelease(trust); | |||
| } | |||
|
|
|||
| - (void)testSettingDuplicateCertificatesProperlyRemovesTheDuplicate { | |||
| AFSecurityPolicy *policy = [AFSecurityPolicy policyWithPinningMode:AFSSLPinningModePublicKey]; | |||
There was a problem hiding this comment.
Should this be AFSSLPinningModeCertificate since you are testing certs here rather than public keys? I realize it really doesn't matter under the hood since the type doesn't affect the removal of duplicate certs.
|
Added your feedback @cnoon 🍻 |
|
Looks good good to me @kcharwood...I'd say merge it! |
kcharwood
added a commit
that referenced
this pull request
Jun 1, 2015
…_certificates Eliminated duplicated pinned certificates
|
hi, kcharwood. great job:) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified an issue that prevents
validatesCertificateChainfrom validating the entire chain if a developer mistakenly pins duplicate certificates.The fix is to simply ensure pinned certificates does not contain any duplicates. This does not represent an actual security vulnerability, as the duplicate certificates still need to be present in the certificate chain of the server trust.
In addition, this problem may also go away in a future version, if we deprecate the
validatesCertificateChainproperty as discussed in #2744For now, we can put this fix into 2.5.5.